tag:blogger.com,1999:blog-5502193732299119611.post7695054699383231164..comments2009-05-26T06:45:10.126-07:00The App Engine Fanhttp://www.blogger.com/profile/14769199738243128956noreply@blogger.comBlogger2125tag:blogger.com,1999:blog-5502193732299119611.post-45376331859874371802009-05-26T06:45:10.126-07:002009-05-26T06:45:10.126-07:00Hi Bob,<br /><br />Thanks for the feedback :-)<br /><br />On test plans: since I've been mostly shifting existing code around so far, I had relied on the existing unit tests to succeed. Worked fine for the most part, except "r25" (created after this post), where I produced a NPE in ServerController. I fixed that in r30, but I have not extended the unit tests yet. It's on my todo list.<br /><br />I'll probably switch from refactoring mode into coding mode soon and work on an http-based protocol. That's the point where more intense unit testing will definitely come into play.<br /><br />Cheers,<br /><br /> JensThe App Engine Fanhttp://www.blogger.com/profile/14769199738243128956noreply@blogger.comtag:blogger.com,1999:blog-5502193732299119611.post-50192092527845844362009-05-26T03:11:57.574-07:002009-05-26T03:11:57.574-07:00This is great work. I always like to see sensible refactoring.<br /><br />The SRP - "Single Responsibility Principle" should be used by every programmer on a daily basis - keeps code clean, easy to understand and easier to maintain.<br /><br />Also, dont forget about writing test plans for this new code!Bob Bloghttp://www.blogger.com/profile/07678079360921750111noreply@blogger.com